Skip to content

[DeadCode] Do not remove parenthess on BinaryOp on RemoveConcatAutocastRector#7503

Merged
samsonasik merged 2 commits intomainfrom
do-not-remove-parentheses
Oct 14, 2025
Merged

[DeadCode] Do not remove parenthess on BinaryOp on RemoveConcatAutocastRector#7503
samsonasik merged 2 commits intomainfrom
do-not-remove-parentheses

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik marked this pull request as draft October 14, 2025 17:01
@samsonasik samsonasik marked this pull request as ready for review October 14, 2025 17:20
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @mpesari

@samsonasik samsonasik changed the title [DeadCode] Do not remove parenthess on RemoveConcatAutocastRector [DeadCode] Do not remove parenthess on BinaryOp on RemoveConcatAutocastRector Oct 14, 2025
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit d28aadd into main Oct 14, 2025
52 checks passed
@samsonasik samsonasik deleted the do-not-remove-parentheses branch October 14, 2025 17:22
@mpesari
Copy link
Contributor

mpesari commented Oct 15, 2025

Thanks!

@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of RemoveConcatAutocastRector

2 participants